[CodeQuality] Skip pull property from inner class on CompleteDynamicP…

…ropertiesRector (#4561)

* [CodeQuality] Skip pull property from inner class on CompleteDynamicPropertiesRector

* Fix

* clean up

* clean up

* clean up

* skip pull from differnt class

packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -451,15 +451,14 @@ private function resolveClassOrInterfaceScope(
             $classReflection = $this->reflectionProvider->getClass($className);
         }
 
-        $context = $this->privatesAccessor->getPrivateProperty($mutatingScope, 'context');
-
         try {
-            $this->privatesAccessor->setPrivateProperty($context, 'classReflection', $classReflection);
             return $mutatingScope->enterClass($classReflection);
         } catch (\PHPStan\ShouldNotHappenException) {
-            $this->privatesAccessor->setPrivateProperty($context, 'classReflection', null);
         }
 
+        $context = $this->privatesAccessor->getPrivateProperty($mutatingScope, 'context');
+        $this->privatesAccessor->setPrivateProperty($context, 'classReflection', null);
+
         return $mutatingScope->enterClass($classReflection);
     }
 

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_inner_class.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;
+
+final class SkipInnerClass
+{
+    public function run()
+    {
+        $box = new class () {
+            public $logged;
+
+            public function hold(string $value)
+            {
+                $this->logged = $value;
+            }
+        };
+
+        echo $box->logged;
+    }
+}

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_pull_from_different_class.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Source\DifferentClass;
+
+class SkipPullFromDifferentClass
+{
+    public function run()
+    {
+        $obj = new DifferentClass();
+        echo $obj->property;
+    }
+}

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Source/DifferentClass.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Source;
+
+class DifferentClass
+{
+    public $property = 'some value';
+}