[Php71] Skip defer() function on RemoveExtraParametersRector (#3211)

* [Php71] Skip defer() function on RemoveExtraParametersRector * Fixed 🎉 * final touch: move to private method to reuse validate * final touch: move to private method to reuse validate * Fix * Final touch: move phpstan.phar check on RemoveExtraParametersReflection
rectorphp · Dec 17, 2022 · 14e60b0 · 14e60b0
1 parent 7d5d1ce
commit 14e60b0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/...sts/Php71/Rector/FuncCall/RemoveExtraParametersRector/Fixture/skip_defer_function.php.inc b/...sts/Php71/Rector/FuncCall/RemoveExtraParametersRector/Fixture/skip_defer_function.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+// no namespace on purpose to demonstrate the issue
+function defer(string $foo, callable $callback): void
+{
+    $callback($foo);
+}
+
+defer("foo", static function ($bar) {
+    echo $bar;
+});
diff --git a/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php b/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php
@@ -87,6 +87,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($this->shouldSkipFunctionReflection($functionLikeReflection)) {
+            return null;
+        }
+
         $numberOfArguments = count($node->getRawArgs());
         if ($numberOfArguments <= $maximumAllowedParameterCount) {
             return null;
@@ -99,6 +103,18 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    private function shouldSkipFunctionReflection(MethodReflection|FunctionReflection $reflection): bool
+    {
+        if ($reflection instanceof FunctionReflection) {
+            $fileName = (string) $reflection->getFileName();
+            if (str_contains($fileName, 'phpstan.phar')) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     private function shouldSkip(FuncCall | MethodCall | StaticCall $call): bool
     {
         if ($call->args === []) {