[TypeDeclaration] Skip unitialized property on EmptyOnNullableObjectT…

…oInstanceOfRector (#5889)

* [TypeDeclaration] Skip unitialized property on EmptyOnNullableObjectToInstanceOfRector

* fixture update

* fixture update

* fixture update

rules-tests/TypeDeclaration/Rector/Empty_/EmptyOnNullableObjectToInstanceOfRector/Fixture/skip_unitialized_property.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector\Source\AnotherObject;
+
+final class SkipUnitializedProperty
+{
+    private AnotherObject $id;
+
+    public function setId(AnotherObject $id): self
+    {
+        if (!empty($this->id) && !$id->equals($this->id)) {
+            throw new \InvalidArgumentException('The ID is already set.');
+        }
+
+        $this->id = $id;
+
+        return $this;
+    }
+}

rules-tests/TypeDeclaration/Rector/Empty_/EmptyOnNullableObjectToInstanceOfRector/Source/AnotherObject.php

@@ -4,5 +4,8 @@
 
 final class AnotherObject
 {
-
+    public function equals(AnotherObject $anotherObject)
+    {
+        return (bool) rand(0, 1);
+    }
 }

rules/TypeDeclaration/Rector/Empty_/EmptyOnNullableObjectToInstanceOfRector.php

@@ -10,17 +10,20 @@
 use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\Instanceof_;
 use PhpParser\Node\Name;
+use PHPStan\Analyser\Scope;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\UnionType;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
-use Rector\Rector\AbstractRector;
+use Rector\Rector\AbstractScopeAwareRector;
 use Rector\StaticTypeMapper\StaticTypeMapper;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**
  * @see \Rector\Tests\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector\EmptyOnNullableObjectToInstanceOfRectorTest
  */
-final class EmptyOnNullableObjectToInstanceOfRector extends AbstractRector
+final class EmptyOnNullableObjectToInstanceOfRector extends AbstractScopeAwareRector
 {
     public function __construct(
         private readonly StaticTypeMapper $staticTypeMapper
@@ -74,7 +77,7 @@ public function getNodeTypes(): array
     /**
      * @param Empty_|BooleanNot $node
      */
-    public function refactor(Node $node): ?Node
+    public function refactorWithScope(Node $node, Scope $scope): null|Instanceof_|BooleanNot
     {
         if ($node instanceof BooleanNot) {
             if (! $node->expr instanceof Empty_) {
@@ -92,7 +95,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $exprType = $this->nodeTypeResolver->getNativeType($empty->expr);
+        $exprType = $scope->getNativeType($empty->expr);
+        if (! $exprType instanceof UnionType) {
+            return null;
+        }
+
+        $exprType = TypeCombinator::removeNull($exprType);
         if (! $exprType instanceof ObjectType) {
             return null;
         }