[Core] AbstractScopeAwareRector is ready to be used in custom rules (#…

…2537)
rectorphp · Jun 20, 2022 · 21fc218 · 21fc218
1 parent f4a9b50
commit 21fc218
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/rules/Php70/Rector/FuncCall/MultiDirnameRector.php b/rules/Php70/Rector/FuncCall/MultiDirnameRector.php
@@ -61,7 +61,7 @@ public function refactor(Node $node): ?Node
         }
 
         // nothing to improve
-        if ($this->shouldSkip()) {
+        if ($this->nestingLevel < 2) {
             return null;
         }
 
@@ -76,11 +76,6 @@ public function provideMinPhpVersion(): int
         return PhpVersionFeature::DIRNAME_LEVELS;
     }
 
-    private function shouldSkip(): bool
-    {
-        return $this->nestingLevel < 2;
-    }
-
     private function matchNestedDirnameFuncCall(FuncCall $funcCall): ?FuncCall
     {
         if (! $this->isName($funcCall, self::DIRNAME)) {

diff --git a/src/Rector/AbstractScopeAwareRector.php b/src/Rector/AbstractScopeAwareRector.php
@@ -10,10 +10,6 @@
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
-/**
- * @internal Currently in experimental testing for core Rector rules. So we can verify if this feature is useful or not.
- * Do not use outside in custom rules. Go for AbstractRector instead.
- */
 abstract class AbstractScopeAwareRector extends AbstractRector implements ScopeAwarePhpRectorInterface
 {
     /**