[Php80] Fix OptionalParametersAfterRequiredRector to treat variadic a…

…s optional (#248) Co-authored-by: Alies Lapatsin <lptn@users.noreply.github.com>
rectorphp · Jun 19, 2021 · 2723dfd · 2723dfd
1 parent e639ed4
commit 2723dfd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...ptionalParametersAfterRequiredRector/Fixture/treat_variadic_parameter_as_optional.php.inc b/...ptionalParametersAfterRequiredRector/Fixture/treat_variadic_parameter_as_optional.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+final class Cart
+{
+    public static function create(string $name = 'default', Product ...$products)
+    {
+        $cart = new Cart($name);
+        $cart->products = $products;
+        return $cart;
+    }
+}
diff --git a/rules/Php80/NodeResolver/RequireOptionalParamResolver.php b/rules/Php80/NodeResolver/RequireOptionalParamResolver.php
@@ -19,7 +19,7 @@ public function resolve(FunctionLike $functionLike): array
         $optionalParams = [];
         $requireParams = [];
         foreach ($functionLike->getParams() as $position => $param) {
-            if ($param->default === null) {
+            if ($param->default === null && ! $param->variadic) {
                 $requireParams[$position] = $param;
             } else {
                 $optionalParams[$position] = $param;