[Php81] Allow nullable union on NullToStrictStringFuncCallArgRector (#…

…5532)

* [Php81] Allow union on NullToStrictStringFuncCallArgRector

* [Php81] Allow union on NullToStrictStringFuncCallArgRector

* [ci-review] Rector Rectify

* [Php81] Allow union on NullToStrictStringFuncCallArgRector

* fix

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/with_nullable_docblock.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+class WithNullableDocblock
+{
+   /**
+     * @var string|null
+     */
+    public $importedId;
+
+    /**
+     * @param string|null $importedId
+     */
+    public function setImportedId($importedId) {
+        if (strlen($this->importedId) > 0) {
+            $this->importedId = $importedId;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+class WithNullableDocblock
+{
+   /**
+     * @var string|null
+     */
+    public $importedId;
+
+    /**
+     * @param string|null $importedId
+     */
+    public function setImportedId($importedId) {
+        if (strlen((string) $this->importedId) > 0) {
+            $this->importedId = $importedId;
+        }
+    }
+}
+
+?>

rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php

@@ -21,12 +21,14 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PHPStan\ParametersAcceptorSelectorVariantsWrapper;
 use Rector\Php81\Enum\NameNullToStrictNullFunctionMap;
 use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\PHPStanStaticTypeMapper\TypeAnalyzer\UnionTypeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Rector\Reflection\ReflectionResolver;
 use Rector\ValueObject\PhpVersionFeature;
@@ -43,7 +45,8 @@ public function __construct(
         private readonly ReflectionResolver $reflectionResolver,
         private readonly ArgsAnalyzer $argsAnalyzer,
         private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly UnionTypeAnalyzer $unionTypeAnalyzer
     ) {
     }
 
@@ -185,7 +188,7 @@ private function processNullToStrictStringOnNodePosition(
             return null;
         }
 
-        if (! $type instanceof MixedType && ! $type instanceof NullType) {
+        if (! $type instanceof MixedType && ! $type instanceof NullType && ! ($type instanceof UnionType && $this->unionTypeAnalyzer->isNullable($type))) {
             return null;
         }