[CodeQuality] Skip combine var with property fetch on InlineArrayRetu…

…rnAssignRector (#5681)

* [CodeQuality] Skip combine var with property fetch on InlineArrayReturnAssignRector

* fix

rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_with_property_fetch.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\Fixture;
+
+final class SkipWithPropertyFetch
+{
+    public function run($person2)
+    {
+        $person = [];
+
+        $person['name'] = 'Timmy';
+        $this->person['name'] = 'Back';
+
+        return $person;
+    }
+}

rules/CodeQuality/NodeAnalyzer/VariableDimFetchAssignResolver.php

@@ -44,7 +44,7 @@ public function resolveFromStmtsAndVariable(array $stmts, Variable $variable): a
             $assign = $stmtExpr;
 
             $keyExpr = $this->matchKeyOnArrayDimFetchOfVariable($assign, $variable);
-            if ($keyExpr instanceof ArrayDimFetch) {
+            if ($assign->var instanceof ArrayDimFetch && $assign->var->var instanceof ArrayDimFetch) {
                 return [];
             }
 
@@ -67,7 +67,7 @@ private function matchKeyOnArrayDimFetchOfVariable(Assign $assign, Variable $var
         }
 
         $arrayDimFetch = $assign->var;
-        if ($arrayDimFetch->var instanceof Variable && ! $this->nodeComparator->areNodesEqual($arrayDimFetch->var, $variable)) {
+        if (! $this->nodeComparator->areNodesEqual($arrayDimFetch->var, $variable)) {
             return null;
         }
 
@@ -80,10 +80,6 @@ private function matchKeyOnArrayDimFetchOfVariable(Assign $assign, Variable $var
             return null;
         }
 
-        if ($arrayDimFetch->var instanceof ArrayDimFetch) {
-            return $arrayDimFetch->var;
-        }
-
         return $arrayDimFetch->dim;
     }