[EarlyReturn] Skip with AssignOp on PreparedValueToEarlyReturnRector (…

…#5857)

* [EarlyReturn] Skip with AssignOp on PreparedValueToEarlyReturnRector

* [EarlyReturn] Skip with AssignOp on PreparedValueToEarlyReturnRector

rules-tests/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector/Fixture/skip_append_variable_value_before_if.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector\Fixture;
+
+final class SkipAppendVariableValueBeforeIf
+{
+	public function getTravelString(bool $shorten, int $range, string $metric, float $distance): string
+	{
+		$label = ($shorten) ? ($metric === 'time' ? ' hrs' : ' mi') : ($metric === 'time' ? ' hours' : ' miles');
+		$range = ($metric === 'time') ? round($range / 60, 1) : $range;
+
+		$travels = ($shorten) ? '' : 'up to ';
+ 		$travels .= $range . $label;
+
+		if ($distance > 3000) {
+			$travels = ($shorten) ? 'any' : 'nationwide';
+		}
+
+		return $travels;
+	}
+}
+
+?>

rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\AssignOp;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Expression;
@@ -101,6 +102,10 @@ public function refactor(Node $node): ?StmtsAwareInterface
         $initialAssignPosition = null;
 
         foreach ($node->stmts as $key => $stmt) {
+            if ($stmt instanceof Expression && $stmt->expr instanceof AssignOp) {
+                return null;
+            }
+
             if ($stmt instanceof If_) {
                 $ifs[$key] = $stmt;
                 continue;