Remove PropertyFetchTypeAnalyzer and it's usages (#3410)

rectorphp · Feb 24, 2023 · 2cca234 · 2cca234
1 parent 9c7da41
commit 2cca234
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 81 deletions.
diff --git a/rules/TypeDeclaration/TypeAnalyzer/PropertyFetchTypeAnalyzer.php b/rules/TypeDeclaration/TypeAnalyzer/PropertyFetchTypeAnalyzer.php
diff --git a/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php
@@ -28,7 +28,6 @@
 use Rector\TypeDeclaration\AlreadyAssignDetector\NullTypeAssignDetector;
 use Rector\TypeDeclaration\AlreadyAssignDetector\PropertyDefaultAssignDetector;
 use Rector\TypeDeclaration\Matcher\PropertyAssignMatcher;
-use Rector\TypeDeclaration\TypeAnalyzer\PropertyFetchTypeAnalyzer;
 
 /**
  * @deprecated
@@ -47,7 +46,6 @@ public function __construct(
         private readonly ExprAnalyzer $exprAnalyzer,
         private readonly ValueResolver $valueResolver,
         private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
-        private readonly PropertyFetchTypeAnalyzer $propertyFetchTypeAnalyzer,
     ) {
     }
 
@@ -200,12 +198,6 @@ private function getAssignedExprTypes(ClassLike $classLike, string $propertyName
                 return null;
             }
 
-            if ($this->propertyFetchAnalyzer->isPropertyFetch($node->expr)
-                && $this->propertyFetchTypeAnalyzer->isPropertyFetchExprNotNativelyTyped($node->expr)
-            ) {
-                return null;
-            }
-
             if ($this->exprAnalyzer->isNonTypedFromParam($node->expr)) {
                 return null;
             }

diff --git a/...TypeDeclaration/TypeInferer/PropertyTypeInferer/TrustedClassMethodPropertyTypeInferer.php b/...TypeDeclaration/TypeInferer/PropertyTypeInferer/TrustedClassMethodPropertyTypeInferer.php
@@ -23,7 +23,6 @@
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\UnionType;
 use Rector\Core\NodeAnalyzer\ParamAnalyzer;
-use Rector\Core\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\Core\NodeManipulator\ClassMethodPropertyFetchManipulator;
 use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\NodeNameResolver\NodeNameResolver;
@@ -35,7 +34,6 @@
 use Rector\StaticTypeMapper\StaticTypeMapper;
 use Rector\StaticTypeMapper\ValueObject\Type\AliasedObjectType;
 use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
-use Rector\TypeDeclaration\TypeAnalyzer\PropertyFetchTypeAnalyzer;
 use Rector\TypeDeclaration\TypeInferer\AssignToPropertyTypeInferer;
 
 /**
@@ -56,8 +54,6 @@ public function __construct(
         private readonly ParamAnalyzer $paramAnalyzer,
         private readonly AssignToPropertyTypeInferer $assignToPropertyTypeInferer,
         private readonly TypeComparator $typeComparator,
-        private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
-        private readonly PropertyFetchTypeAnalyzer $propertyFetchTypeAnalyzer,
     ) {
     }
 
@@ -85,12 +81,6 @@ public function inferProperty(Property $property, ClassMethod $classMethod): Typ
 
         $resolvedTypes = [];
         foreach ($assignedExprs as $assignedExpr) {
-            if ($this->propertyFetchAnalyzer->isPropertyFetch($assignedExpr)
-                && $this->propertyFetchTypeAnalyzer->isPropertyFetchExprNotNativelyTyped($assignedExpr)
-            ) {
-                continue;
-            }
-
             $resolvedTypes[] = $this->nodeTypeResolver->getType($assignedExpr);
         }