[Php73] Skip double escape dash on next with quantifier outside brack…

…et on RegexDashEscapeRector (#1006)

* [Php73] Skip escape dash outside bracket on RegexDashEscapeRector

* rename fixture

* rename

* fix more quantifiers

* final touch

* add more fixture

rules-tests/Php73/Rector/FuncCall/RegexDashEscapeRector/Fixture/skip_double_escape_more_quantifiers.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\Php73\Rector\FuncCall\RegexDashEscapeRector\Fixture;
+
+class SkipDoubleEscapeMoreQuantifiers
+{
+    public function run(string $string)
+    {
+        preg_match('#^\-\s*[0-9]+$#', $string);
+        preg_match('#^\-\s+[0-9]+$#', $string);
+        preg_match('#^\-\s{1,10}[0-9]+$#', $string);
+        preg_match('#^\-\s{1,}[0-9]+$#', $string);
+        preg_match('#^\-\s(ab)*[0-9]+$#', $string);
+        preg_match('#^\-\s(ab){1,10}[0-9]+$#', $string);
+    }
+}
+
+?>

rules-tests/Php73/Rector/FuncCall/RegexDashEscapeRector/Fixture/skip_double_escape_next_non_quantifier.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php73\Rector\FuncCall\RegexDashEscapeRector\Fixture;
+
+class SkipDoubleEscapeNextNonQuantifier
+{
+    public function run(string $string)
+    {
+        preg_match('#^\-\sa[0-9]+$#', $string);
+    }
+}
+
+?>

rules/Php73/Rector/FuncCall/RegexDashEscapeRector.php

@@ -39,9 +39,9 @@ final class RegexDashEscapeRector extends AbstractRector implements MinPhpVersio
 
     /**
      * @var string
-     * @see https://regex101.com/r/TBVme9/3
+     * @see https://regex101.com/r/TBVme9/8
      */
-    private const RIGHT_HAND_UNESCAPED_DASH_REGEX = '#(?<!\[)-(\\\\(w|s|d)[^\?]*?)\]#i';
+    private const RIGHT_HAND_UNESCAPED_DASH_REGEX = '#(?<!\[)-(\\\\(w|s|d)[.*]?)\]#i';
 
     public function __construct(
         private RegexPatternArgumentManipulator $regexPatternArgumentManipulator