[Transform] Handle Multi Assign on NewToConstructorInjectionRector (#714

)

rules-tests/Transform/Rector/New_/NewToConstructorInjectionRector/Fixture/multi_assign.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\Transform\Rector\New_\NewToConstructorInjectionRector\Fixture;
+
+use Rector\Tests\Transform\Rector\New_\NewToConstructorInjectionRector\Source\DummyValidator;
+
+class MultiAssign
+{
+    public function run()
+    {
+        $dummyValidator = $temp =  new DummyValidator();
+        $dummyValidator->validate(100000);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Transform\Rector\New_\NewToConstructorInjectionRector\Fixture;
+
+use Rector\Tests\Transform\Rector\New_\NewToConstructorInjectionRector\Source\DummyValidator;
+
+class MultiAssign
+{
+    public function __construct(private \Rector\Tests\Transform\Rector\New_\NewToConstructorInjectionRector\Source\DummyValidator $dummyValidator)
+    {
+    }
+    public function run()
+    {
+        $this->dummyValidator->validate(100000);
+    }
+}
+
+?>

rules/Transform/Rector/New_/NewToConstructorInjectionRector.php

@@ -15,6 +15,7 @@
 use Rector\Core\Rector\AbstractRector;
 use Rector\Naming\Naming\PropertyNaming;
 use Rector\Naming\ValueObject\ExpectedName;
+use Rector\NodeRemoval\AssignRemover;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PostRector\Collector\PropertyToAddCollector;
 use Rector\PostRector\ValueObject\PropertyMetadata;
@@ -40,7 +41,8 @@ final class NewToConstructorInjectionRector extends AbstractRector implements Co
     public function __construct(
         private PropertyFetchFactory $propertyFetchFactory,
         private PropertyNaming $propertyNaming,
-        private PropertyToAddCollector $propertyToAddCollector
+        private PropertyToAddCollector $propertyToAddCollector,
+        private AssignRemover $assignRemover
     ) {
     }
 
@@ -158,7 +160,7 @@ private function refactorAssign(Assign $assign): void
                 continue;
             }
 
-            $this->removeNode($assign);
+            $this->assignRemover->removeAssignNode($assign);
         }
     }