Fix StrContainsRector when strpos offset is set (#3086)

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

rules-tests/Php80/Rector/NotIdentical/StrContainsRector/Fixture/offset_strpos.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\NotIdentical\StrContainsRector\Fixture;
+
+class OffsetStrpos
+{
+    public function run()
+    {
+        return strpos('abc', 'a', 1) !== false;
+    }
+}
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\NotIdentical\StrContainsRector\Fixture;
+
+class OffsetStrpos
+{
+    public function run()
+    {
+        return str_contains(substr('abc', 1), 'a');
+    }
+}
+?>

rules/Php80/Rector/NotIdentical/StrContainsRector.php

@@ -5,11 +5,14 @@
 namespace Rector\Php80\Rector\NotIdentical;
 
 use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
+use PhpParser\Node\Scalar\LNumber;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -82,6 +85,13 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if (isset($funcCall->args[2])) {
+            if ($this->isName($funcCall->name, 'strpos') && $this->isPositiveInteger($funcCall->args[2]->value)) {
+                $funcCall->args[0] = new Arg($this->nodeFactory->createFuncCall('substr', [$funcCall->args[0], $funcCall->args[2]]));
+            }
+            unset($funcCall->args[2]);
+        }
+
         $funcCall->name = new Name('str_contains');
 
         if ($node instanceof Identical) {
@@ -123,4 +133,13 @@ private function matchIdenticalOrNotIdenticalToFalse(Identical | NotIdentical $e
 
         return null;
     }
+
+    private function isPositiveInteger(Expr $offset): bool
+    {
+        if (! $offset instanceof LNumber) {
+            return false;
+        }
+
+        return $offset->value > 0;
+    }
 }