[CodeQuality] Register SimplifyUselessLastVariableAssignRector to cod…

…e-quality config set (#2993) * [CodeQuality] Register SimplifyUselessLastVariableAssignRector to code-quality config set * [ci-review] Rector Rectify Co-authored-by: GitHub Action <action@github.com>
rectorphp · Oct 16, 2022 · 34040f3 · 34040f3
1 parent 7b1b356
commit 34040f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/config/set/code-quality.php b/config/set/code-quality.php
@@ -46,6 +46,7 @@
 use Rector\CodeQuality\Rector\FuncCall\StrvalToTypeCastRector;
 use Rector\CodeQuality\Rector\FuncCall\UnwrapSprintfOneArgumentRector;
 use Rector\CodeQuality\Rector\FunctionLike\RemoveAlwaysTrueConditionSetInConstructorRector;
+use Rector\CodeQuality\Rector\FunctionLike\SimplifyUselessLastVariableAssignRector;
 use Rector\CodeQuality\Rector\FunctionLike\SimplifyUselessVariableRector;
 use Rector\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector;
 use Rector\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiveTypeRector;
@@ -190,5 +191,6 @@
         TernaryFalseExpressionToIfRector::class,
         InlineConstructorDefaultToPropertyRector::class,
         SimplifyIfExactValueReturnValueRector::class,
+        SimplifyUselessLastVariableAssignRector::class,
     ]);
 };
diff --git a/rules/TypeDeclaration/Helper/PhpDocNullableTypeHelper.php b/rules/TypeDeclaration/Helper/PhpDocNullableTypeHelper.php
@@ -127,12 +127,11 @@ private function hasClosureType(Type $phpDocType): bool
 
     private function hasNullType(Type $phpDocType): bool
     {
-        $isPhpDocTypeContainingNullType = false;
         if ($phpDocType instanceof UnionType) {
             return TypeCombinator::containsNull($phpDocType);
         }
 
-        return $isPhpDocTypeContainingNullType;
+        return false;
     }
 
     /**