[Performance] Remove unused AttributeKey::ARGUMENT_POSITION (#5469)

* [Performance] Remove unused AttributeKey::ARGUMENT_POSITION * [Performance] Remove unused AttributeKey::ARGUMENT_POSITION
rectorphp · Jan 15, 2024 · 34ab8dc · 34ab8dc
1 parent 2ed1e94
commit 34ab8dc
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 21 deletions.
diff --git a/.phpstorm.meta.php b/.phpstorm.meta.php
@@ -57,7 +57,6 @@
     \Rector\NodeTypeResolver\Node\AttributeKey::COMMENTS,
     \Rector\NodeTypeResolver\Node\AttributeKey::VIRTUAL_NODE,
     \Rector\NodeTypeResolver\Node\AttributeKey::PARAMETER_POSITION,
-    \Rector\NodeTypeResolver\Node\AttributeKey::ARGUMENT_POSITION,
     \Rector\NodeTypeResolver\Node\AttributeKey::RAW_VALUE,
 );
 
@@ -75,6 +74,5 @@
     \Rector\NodeTypeResolver\Node\AttributeKey::COMMENTS,
     \Rector\NodeTypeResolver\Node\AttributeKey::VIRTUAL_NODE,
     \Rector\NodeTypeResolver\Node\AttributeKey::PARAMETER_POSITION,
-    \Rector\NodeTypeResolver\Node\AttributeKey::ARGUMENT_POSITION,
     \Rector\NodeTypeResolver\Node\AttributeKey::RAW_VALUE,
 );
diff --git a/src/NodeTypeResolver/Node/AttributeKey.php b/src/NodeTypeResolver/Node/AttributeKey.php
@@ -117,11 +117,6 @@ final class AttributeKey
      */
     public const PARAMETER_POSITION = 'parameter_position';
 
-    /**
-     * @var string
-     */
-    public const ARGUMENT_POSITION = 'argument_position';
-
     /**
      * @var string
      */

diff --git a/src/NodeTypeResolver/NodeScopeAndMetadataDecorator.php b/src/NodeTypeResolver/NodeScopeAndMetadataDecorator.php
@@ -7,7 +7,7 @@
 use PhpParser\Node\Stmt;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitor\CloningVisitor;
-use Rector\NodeTypeResolver\NodeVisitor\FunctionLikeParamArgPositionNodeVisitor;
+use Rector\NodeTypeResolver\NodeVisitor\FunctionLikeParamPositionNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver;
 use Rector\NodeTypeResolver\PHPStan\Scope\ScopeFactory;
 use Rector\PhpParser\NodeTraverser\FileWithoutNamespaceNodeTraverser;
@@ -20,15 +20,15 @@ final class NodeScopeAndMetadataDecorator
     public function __construct(
         CloningVisitor $cloningVisitor,
         private readonly PHPStanNodeScopeResolver $phpStanNodeScopeResolver,
-        FunctionLikeParamArgPositionNodeVisitor $functionLikeParamArgPositionNodeVisitor,
+        FunctionLikeParamPositionNodeVisitor $functionLikeParamPositionNodeVisitor,
         private readonly ScopeFactory $scopeFactory,
         private readonly FileWithoutNamespaceNodeTraverser $fileWithoutNamespaceNodeTraverser
     ) {
         $this->nodeTraverser = new NodeTraverser();
 
         // needed for format preserving printing
         $this->nodeTraverser->addVisitor($cloningVisitor);
-        $this->nodeTraverser->addVisitor($functionLikeParamArgPositionNodeVisitor);
+        $this->nodeTraverser->addVisitor($functionLikeParamPositionNodeVisitor);
     }
 
     /**

diff --git a/...nctionLikeParamArgPositionNodeVisitor.php → .../FunctionLikeParamPositionNodeVisitor.php b/...nctionLikeParamArgPositionNodeVisitor.php → .../FunctionLikeParamPositionNodeVisitor.php
@@ -5,15 +5,11 @@
 namespace Rector\NodeTypeResolver\NodeVisitor;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Expr\New_;
-use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\FunctionLike;
 use PhpParser\NodeVisitorAbstract;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
-final class FunctionLikeParamArgPositionNodeVisitor extends NodeVisitorAbstract
+final class FunctionLikeParamPositionNodeVisitor extends NodeVisitorAbstract
 {
     public function enterNode(Node $node): ?Node
     {
@@ -23,12 +19,6 @@ public function enterNode(Node $node): ?Node
             }
         }
 
-        if ($node instanceof MethodCall || $node instanceof StaticCall || $node instanceof FuncCall || $node instanceof New_) {
-            foreach ($node->args as $position => $arg) {
-                $arg->setAttribute(AttributeKey::ARGUMENT_POSITION, $position);
-            }
-        }
-
         return $node;
     }
 }