[NodeManipulator] Reduce parent lookup on PropertyManipulator under U…

…nset_ (#4273)
rectorphp · Jun 18, 2023 · 3806bb8 · 3806bb8
1 parent 805b7b7
commit 3806bb8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/packages/NodeTypeResolver/Node/AttributeKey.php b/packages/NodeTypeResolver/Node/AttributeKey.php
@@ -226,4 +226,9 @@ final class AttributeKey
      * @var string
      */
     public const IS_IN_LOOP = 'is_in_loop';
+
+    /**
+     * @var string
+     */
+    public const IS_UNSET_VAR = 'is_unset_var';
 }
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php
@@ -13,6 +13,7 @@
 use PhpParser\Node\Stmt\For_;
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
+use PhpParser\Node\Stmt\Unset_;
 use PhpParser\Node\Stmt\While_;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
@@ -46,6 +47,12 @@ static function (Node $subNode): ?int {
             return null;
         }
 
+        if ($node instanceof Unset_) {
+            foreach ($node->vars as $var) {
+                $var->setAttribute(AttributeKey::IS_UNSET_VAR, true);
+            }
+        }
+
         return null;
     }
 }
diff --git a/src/NodeManipulator/PropertyManipulator.php b/src/NodeManipulator/PropertyManipulator.php
@@ -108,8 +108,7 @@ public function isPropertyChangeableExceptConstructor(
                 return true;
             }
 
-            $isInUnset = (bool) $this->betterNodeFinder->findParentType($propertyFetch, Unset_::class);
-            if ($isInUnset) {
+            if ($propertyFetch->getAttribute(AttributeKey::IS_UNSET_VAR) === true) {
                 return true;
             }
         }