[NodeManipulator] Improve IfManipulator::collectNestedIfsWithNonBreak…

…ing() performance (#3720)
rectorphp · May 1, 2023 · 3c7f2e8 · 3c7f2e8
1 parent 0204a23
commit 3c7f2e8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/NodeManipulator/IfManipulator.php b/src/NodeManipulator/IfManipulator.php
@@ -183,15 +183,14 @@ public function collectNestedIfsWithNonBreaking(Foreach_ $foreach): array
             return [];
         }
 
-        $betterNodeFinderFindInstanceOf = $this->betterNodeFinder->findInstanceOf($currentIf->stmts, Return_::class);
+        $return = $this->betterNodeFinder->findFirstInstanceOf($currentIf->stmts, Return_::class);
 
-        if ($betterNodeFinderFindInstanceOf !== []) {
+        if ($return instanceof Return_) {
             return [];
         }
 
-        /** @var Exit_[] $exits */
-        $exits = $this->betterNodeFinder->findInstanceOf($currentIf->stmts, Exit_::class);
-        if ($exits !== []) {
+        $exit = $this->betterNodeFinder->findFirstInstanceOf($currentIf->stmts, Exit_::class);
+        if ($exit instanceof Exit_) {
             return [];
         }