[Php81] Skip ArrayDimFetch from ArrayObject in Assign var on ReadOnly…

…PropertyRector (#2363) * [Php81] Skip ArrayDimFetch from ArrayObject in Assign var on ReadOnlyPropertyRector * Fixed 🎉 * eol
rectorphp · May 26, 2022 · 3da22b0 · 3da22b0
1 parent 66dbb1e
commit 3da22b0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php b/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php
@@ -63,11 +63,11 @@ public function isRead(PropertyFetch | StaticPropertyFetch $node): bool
             return ! $this->assignManipulator->isLeftPartOfAssign($node);
         }
 
-        if (! $this->isArrayDimFetchInImpureFunction($parent, $node)) {
-            return ! $this->assignManipulator->isLeftPartOfAssign($node);
+        if ($this->assignManipulator->isLeftPartOfAssign($parent)) {
+            return false;
         }
 
-        return false;
+        return ! $this->isArrayDimFetchInImpureFunction($parent, $node);
     }
 
     private function isArrayDimFetchInImpureFunction(ArrayDimFetch $arrayDimFetch, Node $node): bool

diff --git a/...adOnlyPropertyRector/Fixture/skip_array_dim_fetch_from_array_object_in_assign_var.php.inc b/...adOnlyPropertyRector/Fixture/skip_array_dim_fetch_from_array_object_in_assign_var.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\Property\ReadOnlyPropertyRector\Fixture;
+
+use ArrayObject;
+
+final class SkipArrayDimFetchFromArrayObjectInAssignVar
+{
+    private ArrayObject $array;
+
+    public function __construct()
+    {
+        $this->array = new ArrayObject();
+    }
+
+    public function getOrSet(int|string $key, mixed $value = null): mixed
+    {
+        return $this->array[$key] ??= $value;
+    }
+}