[DeadCode] Handle fluent call with concat in RemoveUnusedPrivatePrope…

…rtyRector (#73)

rules-tests/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector/Fixture/fluent_call_with_concat.php.inc

@@ -0,0 +1,36 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;
+
+class FluentCallWithConcat
+{
+	private static $directory = 'CacheFactory';
+	private $cacheFactory;
+	private $config;
+
+    public function run()
+	{
+		$this->config             = new Cache();
+		$this->config->storePath .= self::$directory;
+	}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;
+
+class FluentCallWithConcat
+{
+	private static $directory = 'CacheFactory';
+	private $config;
+
+    public function run()
+	{
+		$this->config             = new Cache();
+		$this->config->storePath .= self::$directory;
+	}
+}
+
+?>

rules/Removing/NodeManipulator/ComplexNodeRemover.php

@@ -51,10 +51,13 @@ public function removePropertyAndUsages(Property $property, array $classMethodNa
                 continue;
             }
 
-            // remove assigns
             $assign = $this->resolveAssign($propertyFetch);
-            $this->assignRemover->removeAssignNode($assign);
+            if (! $assign instanceof Assign) {
+                return;
+            }
 
+            // remove assigns
+            $this->assignRemover->removeAssignNode($assign);
             $this->removeConstructorDependency($assign);
         }
 
@@ -95,7 +98,7 @@ private function shouldSkipPropertyForClassMethod(Expr $expr, array $classMethod
     /**
      * @param PropertyFetch|StaticPropertyFetch $expr
      */
-    private function resolveAssign(Expr $expr): Assign
+    private function resolveAssign(Expr $expr): ?Assign
     {
         $assign = $expr->getAttribute(AttributeKey::PARENT_NODE);
 
@@ -104,7 +107,7 @@ private function resolveAssign(Expr $expr): Assign
         }
 
         if (! $assign instanceof Assign) {
-            throw new ShouldNotHappenException("Can't handle this situation");
+            return null;
         }
 
         return $assign;