[Php71] Skip re-assign as string on AssignArrayToStringRector part 2 (#…

…5661)

* [Php71] Skip re-assign as string on AssignArrayToStringRector part 2

* fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string2.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+// not inside function with direct check on purpose
+
+if ($cdate) {
+    $where[] = 'n.sometable <= 1000';
+}
+
+if (empty($where)) {
+    $where = '';
+} else {
+    $where = 'WHERE ' . implode(' AND ', $where);
+}
+
+$sql = 'SELECT something, something FROM table1' . $where;

rules/Php71/Rector/Assign/AssignArrayToStringRector.php

@@ -4,6 +4,7 @@
 
 namespace Rector\Php71\Rector\Assign;
 
+use PHPStan\Type\UnionType;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
@@ -245,7 +246,12 @@ private function refactorAssign(
             return null;
         }
 
-        if ($this->nodeTypeResolver->getNativeType($assign->var)->isArray()->yes()) {
+        $type = $this->nodeTypeResolver->getNativeType($assign->var);
+        if ($type->isArray()->yes()) {
+            return null;
+        }
+
+        if ($type instanceof UnionType) {
             return null;
         }