[TypeDeclaration] Handle infinite loop on type recursive itself on Re…

…turnTypeFromStrictTypedCallRector (#3487)

* [TypeDeclaration] Handle infinite loop on type recursive itself on ReturnTypeFromStrictTypedCallRector

* eol

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/skip_type_recursive_itself.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Source\SomeNode;
+
+class SkipTypeRecursiveCallItself
+{
+    public function run(SomeNode $node)
+    {
+        return $this->oddLevel($node);
+    }
+
+    protected function oddLevel(SomeNode $node)
+    {
+        if ($node->next) {
+            return $this->evenLevel($node->next);
+        }
+        return $node->value;
+    }
+
+    protected function evenLevel(SomeNode $node)
+    {
+        if ($node->next) {
+            return $this->oddLevel($node->next);
+        }
+        return $node->value;
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Source/SomeNode.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Source;
+
+final class SomeNode
+{
+    public ?SomeNode $next;
+    public string $value;
+}

rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnedNodesReturnTypeInfererTypeInferer.php

@@ -143,6 +143,11 @@ private function inferFromReturnedMethodCall(Return_ $return, FunctionLike $orig
             return new MixedType();
         }
 
+        $parentClassMethod = $this->betterNodeFinder->findParentType($return, ClassMethod::class);
+        if ($parentClassMethod === $originalFunctionLike) {
+            return new MixedType();
+        }
+
         return $this->resolveClassMethod($methodReflection, $originalFunctionLike);
     }