[CodeQuality] Skip method call on else on TernaryFalseExpressionToIfR…

…ector (#5373)

* [CodeQuality] Skip method call on else on TernaryFalseExpressionToIfRector

* Fixed 🎉

* add assign in else

* add else check

* use both

* fix

rules-tests/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector/Fixture/skip_method_call_on_else.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Expression\TernaryFalseExpressionToIfRector\Fixture;
+
+final class SkipMethodCallOnElse
+{
+    public function run(bool $param): void
+    {
+        $param ? $this->a() : $this->b();
+    }
+
+    public function a(): void
+    {
+        new HeavyObject1();
+    }
+
+    public function b(): null
+    {
+        new HeavyObject2();
+		return 'b';
+    }
+}

rules-tests/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector/Fixture/skip_method_call_with_assign_on_else.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Expression\TernaryFalseExpressionToIfRector\Fixture;
+
+final class SkipMethodCallWithAssignOnElse
+{
+    public function run(bool $param): void
+    {
+        $param ? $this->a() : $x = $this->b();
+    }
+
+    public function a(): void
+    {
+        new HeavyObject1();
+    }
+
+    public function b(): null
+    {
+        new HeavyObject2();
+		return 'b';
+    }
+}

rules/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector.php

@@ -77,7 +77,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
             return null;
         }
 
-        if ($this->sideEffectNodeDetector->detect($ternary->else, $scope)) {
+        if ($this->sideEffectNodeDetector->detect($ternary->else, $scope) || $this->sideEffectNodeDetector->detectCallExpr($ternary->else, $scope)) {
             return null;
         }