[Core] Ensure define $originalNode before refactor() called to avoid …

…changed during refactor (#4031)
rectorphp · May 30, 2023 · 46d2aac · 46d2aac
1 parent b37e273
commit 46d2aac
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/Rector/AbstractRector.php b/src/Rector/AbstractRector.php
@@ -224,7 +224,10 @@ final public function enterNode(Node $node)
             $previousMemory = memory_get_peak_usage(true);
         }
 
+        // ensure origNode pulled before refactor to avoid changed during refactor, ref https://3v4l.org/YMEGN
+        $originalNode = $node->getAttribute(AttributeKey::ORIGINAL_NODE);
         $refactoredNode = $this->refactor($node);
+
         if ($isDebug) {
             $this->printConsumptions($startTime, $previousMemory);
         }
@@ -244,7 +247,6 @@ final public function enterNode(Node $node)
             throw new ShouldNotHappenException($errorMessage);
         }
 
-        $originalNode = $node->getAttribute(AttributeKey::ORIGINAL_NODE);
         return $this->postRefactorProcess($originalNode, $node, $refactoredNode);
     }