[Performance] Reduce ClassReflection lookup on RemoveUnusedPrivateMet…

…hodRector (#4006) * [Performance] Reduce ClassReflection lookup on RemoveUnusedPrivateMethodRector * [Performance] Reduce ClassReflection lookup on RemoveUnusedPrivateMethodRector
rectorphp · May 28, 2023 · 48991c6 · 48991c6
1 parent 95d3dc9
commit 48991c6
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php
@@ -79,8 +79,14 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         }
 
         $hasChanged = false;
+        $classReflection = null;
+
         foreach ($node->getMethods() as $classMethod) {
-            if ($this->shouldSkip($classMethod)) {
+            if (! $classReflection instanceof ClassReflection) {
+                $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
+            }
+
+            if ($this->shouldSkip($classMethod, $classReflection)) {
                 continue;
             }
 
@@ -99,9 +105,8 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         return null;
     }
 
-    private function shouldSkip(ClassMethod $classMethod): bool
+    private function shouldSkip(ClassMethod $classMethod, ?ClassReflection $classReflection): bool
     {
-        $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
         if (! $classReflection instanceof ClassReflection) {
             return true;
         }