Skip to content

Commit

Permalink
[Core] Rollback ParameterProvider autowire into AbstractRector (#2095)
Browse files Browse the repository at this point in the history
* [Core] Rollback ParameterProvider autowire into AbstractRector

* remove exclude config

* clean up

* [ci-review] Rector Rectify

Co-authored-by: GitHub Action <action@github.com>
  • Loading branch information
samsonasik and actions-user committed Apr 19, 2022
1 parent 0a98c58 commit 5025d25
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 1 addition & 3 deletions rules/Renaming/Rector/Name/RenameClassRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace;
use Rector\Core\Rector\AbstractRector;
use Rector\Renaming\NodeManipulator\ClassRenamer;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;
Expand All @@ -31,8 +30,7 @@ final class RenameClassRector extends AbstractRector implements ConfigurableRect
{
public function __construct(
private readonly RenamedClassesDataCollector $renamedClassesDataCollector,
private readonly ClassRenamer $classRenamer,
private readonly ParameterProvider $parameterProvider,
private readonly ClassRenamer $classRenamer
) {
}

Expand Down
5 changes: 5 additions & 0 deletions src/Rector/AbstractRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
use Rector\StaticTypeMapper\StaticTypeMapper;
use Symfony\Contracts\Service\Attribute\Required;
use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
use Symplify\Skipper\Skipper\Skipper;

/**
Expand Down Expand Up @@ -81,6 +82,8 @@ abstract class AbstractRector extends NodeVisitorAbstract implements PhpRectorIn

protected NodeTypeResolver $nodeTypeResolver;

protected ParameterProvider $parameterProvider;

protected PhpVersionProvider $phpVersionProvider;

protected StaticTypeMapper $staticTypeMapper;
Expand Down Expand Up @@ -137,6 +140,7 @@ public function autowire(
PhpVersionProvider $phpVersionProvider,
ExclusionManager $exclusionManager,
StaticTypeMapper $staticTypeMapper,
ParameterProvider $parameterProvider,
CurrentRectorProvider $currentRectorProvider,
CurrentNodeProvider $currentNodeProvider,
Skipper $skipper,
Expand All @@ -158,6 +162,7 @@ public function autowire(
$this->phpVersionProvider = $phpVersionProvider;
$this->exclusionManager = $exclusionManager;
$this->staticTypeMapper = $staticTypeMapper;
$this->parameterProvider = $parameterProvider;
$this->currentRectorProvider = $currentRectorProvider;
$this->currentNodeProvider = $currentNodeProvider;
$this->skipper = $skipper;
Expand Down
2 changes: 0 additions & 2 deletions utils/compiler/src/PhpScoper/StaticEasyPrefixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ final class StaticEasyPrefixer
'Helmich\TypoScriptParser\Parser\Traverser\Traverser',
// for usage in packages/Testing/PHPUnit/PlatformAgnosticAssertions.php
'PHPUnit\Framework\Constraint\IsEqual',
// used to get parameter value from custom rule
'Symplify\PackageBuilder\Parameter\ParameterProvider',
];

/**
Expand Down

0 comments on commit 5025d25

Please sign in to comment.