[CodingStyle] Reduce parent attribute usage on NameImporter (#4344)

rectorphp · Jun 25, 2023 · 53e4e9f · 53e4e9f
1 parent dfef34d
commit 53e4e9f
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 9 deletions.
diff --git a/packages/NodeTypeResolver/Node/AttributeKey.php b/packages/NodeTypeResolver/Node/AttributeKey.php
@@ -266,4 +266,14 @@ final class AttributeKey
      * @var string
      */
     public const IS_STATICCALL_CLASS_NAME = 'is_staticcall_class_name';
+
+    /**
+     * @var string
+     */
+    public const IS_FUNCCALL_NAME = 'is_funccall_name';
+
+    /**
+     * @var string
+     */
+    public const IS_CONSTFETCH_NAME = 'is_constfetch_name';
 }
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/NameNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/NameNodeVisitor.php
@@ -5,6 +5,8 @@
 namespace Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Namespace_;
@@ -28,6 +30,16 @@ public function enterNode(Node $node): ?Node
             return null;
         }
 
+        if ($node instanceof FuncCall && $node->name instanceof Name) {
+            $node->name->setAttribute(AttributeKey::IS_FUNCCALL_NAME, true);
+            return null;
+        }
+
+        if ($node instanceof ConstFetch) {
+            $node->name->setAttribute(AttributeKey::IS_CONSTFETCH_NAME, true);
+            return null;
+        }
+
         if (!$node instanceof StaticCall) {
             return null;
         }

diff --git a/rules/CodingStyle/Node/NameImporter.php b/rules/CodingStyle/Node/NameImporter.php
@@ -5,11 +5,8 @@
 namespace Rector\CodingStyle\Node;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\ConstFetch;
-use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\GroupUse;
-use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\Node\Stmt\Use_;
 use PhpParser\Node\Stmt\UseUse;
 use PHPStan\Reflection\ReflectionProvider;
@@ -142,11 +139,11 @@ private function importNameAndCollectNewUseStatement(
      */
     private function isNamespaceOrUseImportName(Name $name): bool
     {
-        $parentNode = $name->getAttribute(AttributeKey::PARENT_NODE);
-        if ($parentNode instanceof Namespace_) {
+        if ($name->getAttribute(AttributeKey::IS_NAMESPACE_NAME) === true) {
             return true;
         }
 
+        $parentNode = $name->getAttribute(AttributeKey::PARENT_NODE);
         return $parentNode instanceof UseUse;
     }
 
@@ -164,11 +161,11 @@ private function isFunctionOrConstantImportWithSingleName(Name $name): bool
             return true;
         }
 
-        if ($parentNode instanceof ConstFetch) {
+        if ($name->getAttribute(AttributeKey::IS_CONSTFETCH_NAME) === true) {
             return count($name->getParts()) === 1;
         }
 
-        if ($parentNode instanceof FuncCall) {
+        if ($name->getAttribute(AttributeKey::IS_FUNCCALL_NAME) === true) {
             return count($name->getParts()) === 1;
         }
 
@@ -181,8 +178,7 @@ private function addUseImport(File $file, Name $name, FullyQualifiedObjectType $
             return;
         }
 
-        $parentNode = $name->getAttribute(AttributeKey::PARENT_NODE);
-        if ($parentNode instanceof FuncCall) {
+        if ($name->getAttribute(AttributeKey::IS_FUNCCALL_NAME) === true) {
             $this->useNodesToAddCollector->addFunctionUseImport($fullyQualifiedObjectType);
         } else {
             $this->useNodesToAddCollector->addUseImport($fullyQualifiedObjectType);