[EarlyReturn] Handle crash on assign in if else before on RemoveAlway…

…sElseRector (#2822)

Co-authored-by: Shin <2082119+shinsenter@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>

rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/assign_in_if_else_before.php.inc

@@ -0,0 +1,55 @@
+<?php
+
+namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
+
+function assignInIfElseBefore($can_order_products, $offset, $limit)
+{
+    if (!empty($can_order_products)) {
+        if (!empty($limit)) {
+            if (!empty($offset)) {
+                $can_order_products = array_slice($can_order_products, $offset, $limit);
+            } else {
+                $can_order_products = array_slice($can_order_products, 0, $limit);
+            }
+
+            if (!empty($can_order_products)) {
+                return $can_order_products;
+            } else {
+                return false;
+            }
+        } else {
+            return $can_order_products;
+        }
+    }
+
+    return false;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
+
+function assignInIfElseBefore($can_order_products, $offset, $limit)
+{
+    if (!empty($can_order_products)) {
+        if (!empty($limit)) {
+            if (!empty($offset)) {
+                $can_order_products = array_slice($can_order_products, $offset, $limit);
+            } else {
+                $can_order_products = array_slice($can_order_products, 0, $limit);
+            }
+
+            if (!empty($can_order_products)) {
+                return $can_order_products;
+            }
+            return false;
+        }
+        return $can_order_products;
+    }
+
+    return false;
+}
+
+?>

rules/EarlyReturn/Rector/If_/RemoveAlwaysElseRector.php

@@ -132,6 +132,10 @@ private function doesLastStatementBreakFlow(If_ | ElseIf_ $node): bool
     {
         $lastStmt = end($node->stmts);
 
+        if ($lastStmt instanceof If_ && $lastStmt->else instanceof Else_) {
+            return $this->doesLastStatementBreakFlow($lastStmt);
+        }
+
         return ! ($lastStmt instanceof Return_
             || $lastStmt instanceof Throw_
             || $lastStmt instanceof Continue_