Prevent unnecessary IO in tests (#3814)

* Prevent unnecessary IO in tests * Update ContainerBuilderFactory.php
rectorphp · May 12, 2023 · 5541090 · 5541090
1 parent 5229535
commit 5541090
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/Testing/PHPUnit/AbstractTestCase.php b/packages/Testing/PHPUnit/AbstractTestCase.php
@@ -72,12 +72,15 @@ protected function getService(string $type): object
      */
     private function createConfigsHash(array $configFiles): string
     {
-        Assert::allFile($configFiles);
         Assert::allString($configFiles);
 
         $configHash = '';
         foreach ($configFiles as $configFile) {
-            $configHash .= md5_file($configFile);
+            $hash = md5_file($configFile);
+            if ($hash === false) {
+                throw new ShouldNotHappenException(sprintf('File %s is not readable', $configFile));
+            }
+            $configHash .= $hash;
         }
 
         return $configHash;

diff --git a/src/Kernel/ContainerBuilderFactory.php b/src/Kernel/ContainerBuilderFactory.php
@@ -25,7 +25,6 @@ public function create(array $configFiles, array $compilerPasses): ContainerBuil
         Assert::allIsAOf($compilerPasses, CompilerPassInterface::class);
 
         Assert::allString($configFiles);
-        Assert::allFile($configFiles);
 
         $containerBuilder = new ContainerBuilder();