[CodeQuality] Skip different array_filter value on SimplifyEmptyArray…

…CheckRector (#3000) * [CodeQuality] Skip different array_filter value on SimplifyEmptyArrayCheckRector * Fixed 🎉 * cs fix
rectorphp · Oct 17, 2022 · 56620a9 · 56620a9
1 parent 63976bc
commit 56620a9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...ooleanAnd/SimplifyEmptyArrayCheckRector/Fixture/skip_different_array_filter_value.php.inc b/...ooleanAnd/SimplifyEmptyArrayCheckRector/Fixture/skip_different_array_filter_value.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector\Fixture;
+
+final class SkipDifferentArrayFilterValue
+{
+    public function functionCallInsideEmpty($a, $values): bool
+    {
+        return is_array($a) && empty(array_filter($values));
+    }
+}
diff --git a/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php b/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php
@@ -65,7 +65,10 @@ public function refactor(Node $node): ?Node
         /** @var Empty_ $emptyOrNotIdenticalNode */
         $emptyOrNotIdenticalNode = $twoNodeMatch->getSecondExpr();
 
-        if ($emptyOrNotIdenticalNode->expr instanceof FuncCall) {
+        if ($emptyOrNotIdenticalNode->expr instanceof FuncCall && $this->nodeComparator->areNodesEqual(
+            $emptyOrNotIdenticalNode->expr->args[0]->value,
+            $firstArgValue
+        )) {
             return new Identical($emptyOrNotIdenticalNode->expr, new Array_());
         }