[Php70] Fix Php4 contructor not replaced with __construct() on php 7.…

…4 environment (#5189)
rectorphp · Oct 19, 2023 · 5ac3cb3 · 5ac3cb3
1 parent 4795d00
commit 5ac3cb3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...sts/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/skip_only_other_method.php.inc b/...sts/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/skip_only_other_method.php.inc
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+class SkipOnlyOtherMethod
+{
+    public function run()
+    {
+    }
+}
diff --git a/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php b/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php
@@ -107,7 +107,7 @@ public function refactorWithScope(Node $node, Scope $scope): Class_|int|null
         $this->processClassMethodStatementsForParentConstructorCalls($psr4ConstructorMethod, $scope);
 
         // does it already have a __construct method?
-        if (! $classReflection->hasConstructor()) {
+        if (! $classReflection->hasNativeMethod(MethodName::CONSTRUCT)) {
             $psr4ConstructorMethod->name = new Identifier(MethodName::CONSTRUCT);
         }