[Performance][Php80] Avoid print on Expr when possible on AddParamBas…

…edOnParentClassMethodRector (#4839) * [Performance][Php80] Avoid print on Expr on AddParamBasedOnParentClassMethodRector * clean up comment
rectorphp · Aug 23, 2023 · 5de9824 · 5de9824
1 parent 15ddec3
commit 5de9824
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php b/rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php
@@ -245,11 +245,6 @@ function (Node $subNode) use ($parentClassMethodParam): bool {
     private function resolveParamDefault(Expr $expr): Expr
     {
         // re-create to avoid TokenStream error
-        $printParamDefault = $this->betterStandardPrinter->print($expr);
-        if ($printParamDefault === '[]') {
-            return new Array_([]);
-        }
-
         if ($expr instanceof String_ && $expr->value === '') {
             return new String_($expr->value);
         }
@@ -262,6 +257,11 @@ private function resolveParamDefault(Expr $expr): Expr
             return new DNumber($expr->value);
         }
 
+        $printParamDefault = $this->betterStandardPrinter->print($expr);
+        if ($printParamDefault === '[]') {
+            return new Array_([]);
+        }
+
         return new ConstFetch(new Name($printParamDefault));
     }