[DeadCode] Skip UnwrapFutureCompatibleIfPhpVersionRector on higher th…

…an current php provider (#685)

rules-tests/DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector/Fixture/skip_higher_current.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector\Fixture;
+
+class SkipHigherCurrent
+{
+    public function run()
+    {
+        // $this->phpVersionProvider->provide() returns 10000 on test
+        if (version_compare(PHP_VERSION, '11.0', '<')) {
+            return 'a';
+        } else {
+            return 'b';
+        }
+    }
+}
+
+?>

rules/DeadCode/ConditionEvaluator.php

@@ -9,12 +9,17 @@
 use PhpParser\Node\Expr\BinaryOp\NotEqual;
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use Rector\Core\Exception\ShouldNotHappenException;
+use Rector\Core\Php\PhpVersionProvider;
 use Rector\DeadCode\Contract\ConditionInterface;
 use Rector\DeadCode\ValueObject\BinaryToVersionCompareCondition;
 use Rector\DeadCode\ValueObject\VersionCompareCondition;
 
 final class ConditionEvaluator
 {
+    public function __construct(private PhpVersionProvider $phpVersionProvider)
+    {
+    }
+
     /**
      * @return bool|int|null
      */
@@ -31,10 +36,14 @@ public function evaluate(ConditionInterface $condition)
         return null;
     }
 
-    private function evaluateVersionCompareCondition(VersionCompareCondition $versionCompareCondition): bool | int
+    private function evaluateVersionCompareCondition(VersionCompareCondition $versionCompareCondition): bool | int | null
     {
         $compareSign = $versionCompareCondition->getCompareSign();
         if ($compareSign !== null) {
+            if ($compareSign === '<' && $this->phpVersionProvider->provide() < $versionCompareCondition->getSecondVersion()) {
+                return null;
+            }
+
             return version_compare(
                 (string) $versionCompareCondition->getFirstVersion(),
                 (string) $versionCompareCondition->getSecondVersion(),