[Php73] Handle crash on JsonThrowOnErrorRector + SensitiveConstantNam…

…eRector (#5253)

* [Php73] Handle crash on JsonThrowOnErrorRector + SensitiveConstantNameRector

* Fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php

@@ -8,9 +8,8 @@
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
-use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ReflectionProvider;
-use Rector\Core\Rector\AbstractScopeAwareRector;
+use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -21,7 +20,7 @@
  *
  * @see \Rector\Tests\Php73\Rector\ConstFetch\SensitiveConstantNameRector\SensitiveConstantNameRectorTest
  */
-final class SensitiveConstantNameRector extends AbstractScopeAwareRector implements MinPhpVersionInterface
+final class SensitiveConstantNameRector extends AbstractRector implements MinPhpVersionInterface
 {
     /**
      * @see http://php.net/manual/en/reserved.constants.php
@@ -129,7 +128,7 @@ public function getNodeTypes(): array
     /**
      * @param ConstFetch $node
      */
-    public function refactorWithScope(Node $node, Scope $scope): ?Node
+    public function refactor(Node $node): ?Node
     {
         $constantName = $this->getName($node);
         if ($constantName === null) {
@@ -144,7 +143,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         }
 
         // constant is defined in current lower/upper case
-        if ($this->reflectionProvider->hasConstant(new Name($constantName), $scope)) {
+        if ($this->reflectionProvider->hasConstant(new Name($constantName), null)) {
             return null;
         }
 

tests/Issues/ScopeNotAvailable/FixtureJsonThrowCaseSensitiveConstFetch/fixture.php.inc

@@ -0,0 +1,51 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\ScopeNotAvailable\FixtureJsonThrowCaseSensitiveConstFetch;
+
+class Fixture
+{
+    public static function run()
+    {
+        $user = $_REQUEST['param'];
+
+        $user = json_decode($user);
+
+        $condition = true;
+        if ($condition) {
+            $output = [];
+            echo(json_encode($output));
+            exit;
+        }
+
+        $output = [];
+        echo(json_encode($output));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Core\Tests\Issues\ScopeNotAvailable\FixtureJsonThrowCaseSensitiveConstFetch;
+
+class Fixture
+{
+    public static function run()
+    {
+        $user = $_REQUEST['param'];
+
+        $user = json_decode($user, null, 512, JSON_THROW_ON_ERROR);
+
+        $condition = true;
+        if ($condition) {
+            $output = [];
+            echo(json_encode($output));
+            exit;
+        }
+
+        $output = [];
+        echo(json_encode($output, JSON_THROW_ON_ERROR));
+    }
+}
+
+?>

tests/Issues/ScopeNotAvailable/JsonThrowCaseSensitiveConstFetchTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\ScopeNotAvailable;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class JsonThrowCaseSensitiveConstFetchTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/FixtureJsonThrowCaseSensitiveConstFetch');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/json_throw_case_sensitive_const_fetch.php';
+    }
+}

tests/Issues/ScopeNotAvailable/config/json_throw_case_sensitive_const_fetch.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
+use Rector\Php73\Rector\ConstFetch\SensitiveConstantNameRector;
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        JsonThrowOnErrorRector::class,
+        SensitiveConstantNameRector::class
+    ]);
+};