[DeadCode] Skip RemoveAlwaysTrueIfConditionRector on property use by @…

…var docblock on Trait (#2729)

* [DeadCode] Skip RemoveAlwaysTrueIfConditionRector on property use by @var docblock on Trait

* Fixed 🎉

rules-tests/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/skip_property_by_var_doc_in_trait.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector\Fixture;
+
+trait SkipPropertyByVarDocInTrait
+{
+    /** @var Formatter|null */
+    private $formatter;
+
+    public function verify()
+    {
+        // if we don't have a formatter, make one
+        if (! isset($this->formatter)) {
+            // if no formatter, use the default
+            $this->formatter = new Formatter();
+        }
+
+        $this->formatter->format();
+    }
+}

rules/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector.php

@@ -115,7 +115,8 @@ private function shouldSkipPropertyFetch(Expr $expr): bool
             $classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($propertyFetch);
 
             if (! $classReflection instanceof ClassReflection) {
-                continue;
+                // cannot get parent Trait_ from Property Fetch
+                return true;
             }
 
             $propertyName = (string) $this->nodeNameResolver->getName($propertyFetch);