Improve LocalMethodCallFinder performance (#3651)

rectorphp · Apr 22, 2023 · 6374ccd · 6374ccd
1 parent d490fe5
commit 6374ccd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/PhpParser/NodeFinder/LocalMethodCallFinder.php b/src/PhpParser/NodeFinder/LocalMethodCallFinder.php
@@ -44,16 +44,16 @@ public function match(ClassMethod $classMethod): array
         $matchingMethodCalls = [];
 
         foreach ($methodCalls as $methodCall) {
-            $callerType = $this->nodeTypeResolver->getType($methodCall->var);
-            if (! $callerType instanceof TypeWithClassName) {
+            if (! $this->nodeNameResolver->isName($methodCall->name, $classMethodName)) {
                 continue;
             }
 
-            if ($callerType->getClassName() !== $className) {
+            $callerType = $this->nodeTypeResolver->getType($methodCall->var);
+            if (! $callerType instanceof TypeWithClassName) {
                 continue;
             }
 
-            if (! $this->nodeNameResolver->isName($methodCall->name, $classMethodName)) {
+            if ($callerType->getClassName() !== $className) {
                 continue;
             }