Handle $reflectionProperty->getDefaultValueExpression() return null (#…

…3446) * Handle $reflectionProperty->getDefaultValueExpression() return null * fix * fix * pull from BetterReflection
rectorphp · Mar 3, 2023 · 658e48f · 658e48f
1 parent ef959c7
commit 658e48f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php
@@ -162,8 +162,14 @@ private function isPropertyFetchWithArrayDefault(Expr $expr): bool
         $phpPropertyReflection = $this->reflectionResolver->resolvePropertyReflectionFromPropertyFetch($expr);
         if ($phpPropertyReflection instanceof PhpPropertyReflection) {
             $reflectionProperty = $phpPropertyReflection->getNativeReflection();
+            $betterReflection = $reflectionProperty->getBetterReflection();
+            $defaultValueExpr = $betterReflection->getDefaultValueExpression();
 
-            $defaultValueType = $this->nodeTypeResolver->getType($reflectionProperty->getDefaultValueExpression());
+            if (! $defaultValueExpr instanceof Expr) {
+                return false;
+            }
+
+            $defaultValueType = $this->nodeTypeResolver->getType($defaultValueExpr);
             return $defaultValueType->isArray()
                 ->yes();
         }