[Privatization] Skip Property unsetted on ChangeReadOnlyPropertyWithD…

…efaultValueToConstantRector (#2981)

packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php

@@ -67,7 +67,11 @@ public function isRead(PropertyFetch | StaticPropertyFetch $node): bool
             return false;
         }
 
-        return ! $this->isArrayDimFetchInImpureFunction($parentNode, $node);
+        if (! $this->isArrayDimFetchInImpureFunction($parentNode, $node)) {
+            return $this->isNotInsideIssetUnset($parentNode);
+        }
+
+        return false;
     }
 
     private function isArrayDimFetchInImpureFunction(ArrayDimFetch $arrayDimFetch, Node $node): bool

rules-tests/Privatization/Rector/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_parent_array_dim_fetch.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector\Fixture;
+
+final class SkipUnsettedParentArrayDimFetch {
+    private static $array = ['foo' => 'bar'];
+
+    public function run() {
+        unset(self::$array['foo']);
+    }
+}

rules-tests/Privatization/Rector/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_property_fetch.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector\Fixture;
+
+final class SkipUnsettedPropertyFetch {
+    private $array = ['foo' => 'bar'];
+
+    public function run() {
+        unset($this->array);
+    }
+}

src/NodeManipulator/PropertyManipulator.php

@@ -301,7 +301,7 @@ private function isChangeableContext(PropertyFetch | StaticPropertyFetch $proper
             return ! $this->readWritePropertyAnalyzer->isRead($propertyFetch);
         }
 
-        return false;
+        return $parentNode instanceof Unset_;
     }
 
     private function isFoundByRefParam(MethodCall | StaticCall $node): bool