[CodingStyle][EarlyReturn] Fix infinite if else on BinarySwitchToIfEl…

…seRector+RemoveAlwaysElseRector (#5057)

* [CodingStyle][EarlyReturn] Fix infinite if else on BinarySwitchToIfElseRector+RemoveAlwaysElseRector

* [ci-review] Rector Rectify

* clean up

* clean up

---------

Co-authored-by: GitHub Action <actions@github.com>

src/ProcessAnalyzer/RectifiedAnalyzer.php

@@ -45,7 +45,7 @@ private function hasConsecutiveCreatedByRule(string $rectorClass, Node $node, ?N
         $createdByRule = $createdByRuleNode->getAttribute(AttributeKey::CREATED_BY_RULE) ?? [];
 
         if ($createdByRule === []) {
-            return false;
+            return ! $originalNode instanceof Node && count($node->getAttributes()) <= 1;
         }
 
         return end($createdByRule) === $rectorClass;

tests/Issues/InfiniteIfElse/Fixture/fixture.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InfiniteIfElse\Fixture;
+
+class Fixture
+{
+    public static function getMethod(): int {
+        switch (mt_rand()) {
+            case 1:
+                return 10;
+            case 2:
+                return 20;
+        }
+        return 30;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InfiniteIfElse\Fixture;
+
+class Fixture
+{
+    public static function getMethod(): int {
+        if (mt_rand() == 1) {
+            return 10;
+        } elseif (mt_rand() == 2) {
+            return 20;
+        }
+        return 30;
+    }
+}
+
+?>

tests/Issues/InfiniteIfElse/InfiniteIfElseTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InfiniteIfElse;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class InfiniteIfElseTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/InfiniteIfElse/config/configured_rule.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\CodingStyle\Rector\Switch_\BinarySwitchToIfElseRector;
+use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        BinarySwitchToIfElseRector::class,
+        RemoveAlwaysElseRector::class,
+    ]);
+};

tests/Issues/SimplifyEmpty/Fixture/fixture.php.inc

@@ -54,7 +54,7 @@ class Fixture {
 
     public function check(): bool
     {
-        return $this->getString() !== null && $this->getString() !== '' && !(($this->getString2() === null || $this->getString2() === '') && !is_numeric($this->getString2()));
+        return !($this->getString() === null || $this->getString() === '' || (($this->getString2() === null || $this->getString2() === '') && !is_numeric($this->getString2())));
     }
 }