[CodeQuality] Skip Always return in try catch with finally on Explici…

…tReturnNullRector (#5807)

* [CodeQuality] Skip Always return in try catch with finally on ExplicitReturnNullRector

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/skip_always_returned_in_try_catch_with_finally.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class SkipAlwaysReturnInTryCatchWithFinally
+{
+    public function run(int $number)
+    {
+        if (rand(0, 1)) {
+            try {
+                return execute();
+            } catch (\Exception $e) {
+                return 2;
+            } finally {
+                echo 'here executed after return';
+            }
+         } else {
+             return 2;
+         }
+    }
+}

rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php

@@ -175,19 +175,27 @@ private function isSwitchWithAlwaysReturnOrExit(Switch_ $switch): bool
 
     private function isTryCatchAlwaysReturnOrExit(TryCatch $tryCatch): bool
     {
+        $hasReturnOrExitInFinally = $tryCatch->finally instanceof Finally_ && $this->hasStmtsAlwaysReturnOrExit(
+            $tryCatch->finally->stmts
+        );
+
         if (! $this->hasStmtsAlwaysReturnOrExit($tryCatch->stmts)) {
-            return false;
+            return $hasReturnOrExitInFinally;
         }
 
         foreach ($tryCatch->catches as $catch) {
-            if (! $this->hasStmtsAlwaysReturnOrExit($catch->stmts)) {
-                return false;
+            if ($this->hasStmtsAlwaysReturnOrExit($catch->stmts)) {
+                continue;
             }
+
+            if ($hasReturnOrExitInFinally) {
+                continue;
+            }
+
+            return false;
         }
 
-        return ! ($tryCatch->finally instanceof Finally_ && ! $this->hasStmtsAlwaysReturnOrExit(
-            $tryCatch->finally->stmts
-        ));
+        return true;
     }
 
     private function resolveReturnOrExitCount(Switch_ $switch): int