PHP80 string helpers loose comparison (#3246)

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/fixture_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, -strlen($needle)) == $needle;
+
+        $isMatch = $needle == substr($haystack, -strlen($needle));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        $isMatch = str_ends_with($haystack, $needle);
+
+        $isMatch = str_ends_with($haystack, $needle);
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/hardcoded_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class HardCoded
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, -3) == 'foo';
+
+        $isMatch = 'foo' == substr($haystack, -3);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class HardCoded
+{
+    public function run()
+    {
+        $isMatch = str_ends_with($haystack, 'foo');
+
+        $isMatch = str_ends_with($haystack, 'foo');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/hardcoded_not_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class HardCodedNotIdentical
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, -3) != 'foo';
+
+        $isMatch = 'foo' != substr($haystack, -3);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class HardCodedNotIdentical
+{
+    public function run()
+    {
+        $isMatch = !str_ends_with($haystack, 'foo');
+
+        $isMatch = !str_ends_with($haystack, 'foo');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/skip_substr_compare_not_equal_zero.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SkipSubstrCompareNotZero
+{
+    public function run()
+    {
+        $isMatch = substr_compare($haystack, $needle, -strlen($needle)) == 3;
+
+        $isMatch = 3 == substr_compare($haystack, $needle, -strlen($needle));
+    }
+}

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_compare_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompare
+{
+    public function run()
+    {
+        $isMatch = substr_compare($haystack, $needle, -strlen($needle)) == 0;
+
+        $isMatch = 0 == substr_compare($haystack, $needle, -strlen($needle));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompare
+{
+    public function run()
+    {
+        $isMatch = str_ends_with($haystack, $needle);
+
+        $isMatch = str_ends_with($haystack, $needle);
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_compare_equal_hardcoded.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompare
+{
+    public function run()
+    {
+        $isMatch = substr_compare($haystack, 'needle', -6) == 0;
+
+        $isMatch = 0 == substr_compare($haystack, 'needle', -6);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompare
+{
+    public function run()
+    {
+        $isMatch = str_ends_with($haystack, 'needle');
+
+        $isMatch = str_ends_with($haystack, 'needle');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_compare_not_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompareNot
+{
+    public function run()
+    {
+        $isNotMatch = substr_compare($haystack, $needle, -strlen($needle)) != 0;
+
+        $isNotMatch = 0 != substr_compare($haystack, $needle, -strlen($needle));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompareNot
+{
+    public function run()
+    {
+        $isNotMatch = !str_ends_with($haystack, $needle);
+
+        $isNotMatch = !str_ends_with($haystack, $needle);
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_compare_not_equal_hardcoded.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompareNot
+{
+    public function run()
+    {
+        $isNotMatch = substr_compare($haystack, 'needle', -6) != 0;
+
+        $isNotMatch = 0 != substr_compare($haystack, 'needle', -6);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrCompareNot
+{
+    public function run()
+    {
+        $isNotMatch = !str_ends_with($haystack, 'needle');
+
+        $isNotMatch = !str_ends_with($haystack, 'needle');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/substr_not_equal_prefix.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrNotPrefix
+{
+    public function run()
+    {
+        $isNotMatch = substr($haystack, -strlen($needle)) != $needle;
+
+        $isNotMatch = $needle != substr($haystack, -strlen($needle));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrEndsWithRector\Fixture;
+
+class SubstrNotPrefix
+{
+    public function run()
+    {
+        $isNotMatch = !str_ends_with($haystack, $needle);
+
+        $isNotMatch = !str_ends_with($haystack, $needle);
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/fixture_equal.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, 0, strlen($needle)) == $needle;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        $isMatch = str_starts_with($haystack, $needle);
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/hardcoded_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class HardCoded
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, 0, 3) == 'foo';
+
+        $isMatch = 'foo' == substr($haystack, 0, 3);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class HardCoded
+{
+    public function run()
+    {
+        $isMatch = str_starts_with($haystack, 'foo');
+
+        $isMatch = str_starts_with($haystack, 'foo');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/hardcoded_not_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class HardCodedNotIdentical
+{
+    public function run()
+    {
+        $isMatch = substr($haystack, 0, 3) != 'foo';
+
+        $isMatch = 'foo' != substr($haystack, 0, 3);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class HardCodedNotIdentical
+{
+    public function run()
+    {
+        $isMatch = !str_starts_with($haystack, 'foo');
+
+        $isMatch = !str_starts_with($haystack, 'foo');
+    }
+}
+
+?>

rules-tests/Php80/Rector/Identical/StrStartsWithRector/Fixture/not_equal_substr.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class NotIdenticalSubstr
+{
+    public function run()
+    {
+        $isNotMatch = substr($haystack, 0, strlen($needle)) != $needle;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Identical\StrStartsWithRector\Fixture;
+
+class NotIdenticalSubstr
+{
+    public function run()
+    {
+        $isNotMatch = !str_starts_with($haystack, $needle);
+    }
+}
+
+?>