[StaticTypeMapper] Remove parent attribute usage on FullyQualifiedObj…

…ectType (#4347) * [StaticTypeMapper] Remove parent attribute usage on FullyQualifiedObjectType * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
rectorphp · Jun 25, 2023 · 6cc42eb · 6cc42eb
1 parent beca17d
commit 6cc42eb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php b/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php
@@ -10,6 +10,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeWithClassName;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 
 /**
  * @api
@@ -31,6 +32,8 @@ public function getFullyQualifiedName(): string
     public function getUseNode(): Use_
     {
         $name = new Name($this->fullyQualifiedClass);
+        $name->setAttribute(AttributeKey::IS_USEUSE_NAME, true);
+
         $useUse = new UseUse($name, $this->getClassName());
         return new Use_([$useUse]);
     }
@@ -48,6 +51,8 @@ public function areShortNamesEqual(self | FullyQualifiedObjectType $comparedObje
     public function getFunctionUseNode(): Use_
     {
         $name = new Name($this->fullyQualifiedClass);
+        $name->setAttribute(AttributeKey::IS_USEUSE_NAME, true);
+
         $useUse = new UseUse($name, $this->getClassName());
 
         $use = new Use_([$useUse]);

diff --git a/packages/StaticTypeMapper/ValueObject/Type/FullyQualifiedObjectType.php b/packages/StaticTypeMapper/ValueObject/Type/FullyQualifiedObjectType.php
@@ -52,19 +52,19 @@ public function getShortNameNode(): Name
     public function getUseNode(): Use_
     {
         $name = new Name($this->getClassName());
-        $useUse = new UseUse($name);
+        $name->setAttribute(AttributeKey::IS_USEUSE_NAME, true);
 
-        $name->setAttribute(AttributeKey::PARENT_NODE, $useUse);
+        $useUse = new UseUse($name);
 
         return new Use_([$useUse]);
     }
 
     public function getFunctionUseNode(): Use_
     {
         $name = new Name($this->getClassName());
-        $useUse = new UseUse($name, null);
+        $name->setAttribute(AttributeKey::IS_USEUSE_NAME, true);
 
-        $name->setAttribute(AttributeKey::PARENT_NODE, $useUse);
+        $useUse = new UseUse($name, null);
 
         $use = new Use_([$useUse]);
         $use->type = Use_::TYPE_FUNCTION;

diff --git a/rules/CodingStyle/Node/NameImporter.php b/rules/CodingStyle/Node/NameImporter.php
@@ -5,7 +5,6 @@
 namespace Rector\CodingStyle\Node;
 
 use PhpParser\Node\Name;
-use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\GroupUse;
 use PhpParser\Node\Stmt\Use_;
 use Rector\CodingStyle\ClassNameImport\AliasUsesResolver;
@@ -140,11 +139,7 @@ private function isNamespaceOrUseImportName(Name $name): bool
             return true;
         }
 
-        if ($name->getAttribute(AttributeKey::IS_USEUSE_NAME) === true) {
-            return true;
-        }
-
-        return ! $name instanceof FullyQualified;
+        return $name->getAttribute(AttributeKey::IS_USEUSE_NAME) === true;
     }
 
     private function isFunctionOrConstantImportWithSingleName(Name $name): bool