[Core] Fix ConfigurableCallValuesCollectingPhpFileLoader::import() $s…

…ourceResource type (#140) * [Core] Fix ConfigurableCallValuesCollectingPhpFileLoader::import() $sourceResource type * phpstan * fix
rectorphp · Jun 2, 2021 · 6f7cd6e · 6f7cd6e
1 parent 57d45e8
commit 6f7cd6e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -493,3 +493,11 @@ parameters:
 
         # should be refactored to collector
         - '#Cognitive complexity for "Rector\\CodingStyle\\Naming\\NameRenamer\:\:renameNameNode\(\)" is 10, keep it under 9#'
+
+        -
+            message: '#Removing parent param type is forbidden#'
+            path: src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php #39
+
+        -
+            message: '#Method parameters must be compatible with its parent#'
+            path: src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php #39
diff --git a/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php b/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php
@@ -37,9 +37,10 @@ public function import(
         $resource,
         string $type = null,
         $ignoreErrors = false,
-        string $sourceResource = null,
+        $sourceResource = null,
         $exclude = null
-    ) {
+    )
+    {
         // this call collects root values
         $this->collectConfigureCallsFromJustImportedConfigurableRectorDefinitions();