[TypeDeclaration][Performance] Check typed param already early on Par…

…amTypeByMethodCallTypeRector (#5295)
rectorphp · Nov 28, 2023 · 765b636 · 765b636
1 parent 118fbde
commit 765b636
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php
@@ -170,15 +170,15 @@ static function (Node $node) {
 
     private function shouldSkipParam(Param $param, ClassMethod $classMethod): bool
     {
-        if (! $this->paramTypeAddGuard->isLegal($param, $classMethod)) {
+        // already has type, skip
+        if ($param->type !== null) {
             return true;
         }
 
         if ($param->variadic) {
             return true;
         }
 
-        // already has type, skip
-        return $param->type !== null;
+        return ! $this->paramTypeAddGuard->isLegal($param, $classMethod);
     }
 }