[CodingStyle] Handle crash on empty cases on BinarySwitchToIfElseRect…

…or (#4618) * [CodingStyle] Handle crash on empty cases on BinarySwitchToIfElseRector * Fixed 🎉 * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
rectorphp · Jul 29, 2023 · 784894e · 784894e
1 parent 42c4c63
commit 784894e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/...ts/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector/Fixture/skip_empty_cases.php.inc b/...ts/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector/Fixture/skip_empty_cases.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Switch_\BinarySwitchToIfElseRector\Fixture;
+
+final class SkipEmptyCases
+{
+    public function run()
+    {
+        switch(true) {
+        }
+    }
+}
diff --git a/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php b/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php
@@ -69,7 +69,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (count($node->cases) > 2) {
+        if ($node->cases === [] || count($node->cases) > 2) {
             return null;
         }
 

diff --git a/src/PhpParser/NodeFinder/PropertyFetchFinder.php b/src/PhpParser/NodeFinder/PropertyFetchFinder.php
@@ -4,6 +4,7 @@
 
 namespace Rector\Core\PhpParser\NodeFinder;
 
+use PHPStan\Type\StaticType;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrayDimFetch;
@@ -141,7 +142,7 @@ public function isLocalPropertyFetchByName(Expr $expr, Class_|Trait_ $class, str
         }
 
         $type = $this->nodeTypeResolver->getType($expr->var);
-        if ($type instanceof \PHPStan\Type\StaticType || $type instanceof FullyQualifiedObjectType) {
+        if ($type instanceof StaticType || $type instanceof FullyQualifiedObjectType) {
             return $this->nodeNameResolver->isName($class, $type->getClassName());
         }