[CodeQuality] Handle class-string case insensitive on CompleteDynamic…

…PropertiesRector (#3260)

packages/NodeTypeResolver/NodeTypeCorrector/GenericClassStringTypeCorrector.php

@@ -4,6 +4,7 @@
 
 namespace Rector\NodeTypeResolver\NodeTypeCorrector;
 
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\Generic\GenericClassStringType;
@@ -26,11 +27,18 @@ public function correct(Type $mainType): Type
                 return $traverseCallback($traversedType);
             }
 
-            if (! $this->reflectionProvider->hasClass($traversedType->getValue())) {
+            $value = $traversedType->getValue();
+            if (! $this->reflectionProvider->hasClass($value)) {
                 return $traverseCallback($traversedType);
             }
 
-            return new GenericClassStringType(new ObjectType($traversedType->getValue()));
+            /** @var ClassReflection $classReflection */
+            $classReflection = $this->reflectionProvider->getClass($value);
+            if ($classReflection->getName() !== $value) {
+                return $traverseCallback($traversedType);
+            }
+
+            return new GenericClassStringType(new ObjectType($value));
         });
     }
 }

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/class_string_case_insensitive.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+/** No namespace on purpose to simplify demo that case insensitive string should not be marked as class-string */
+class ClassStringCaseInsensitive
+{
+    public function set()
+    {
+        $this->value = 'classStringCaseInSensitive';
+    }
+}
+
+?>
+-----
+<?php
+
+/** No namespace on purpose to simplify demo that case insensitive string should not be marked as class-string */
+class ClassStringCaseInsensitive
+{
+    /**
+     * @var string
+     */
+    public $value;
+    public function set()
+    {
+        $this->value = 'classStringCaseInSensitive';
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/class_string_case_sensitive.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+/** No namespace on purpose to simplify demo that case sensitive string should be marked as class-string */
+class ClassStringCaseSensitive
+{
+    public function set()
+    {
+        $this->value = 'ClassStringCaseSensitive';
+    }
+}
+
+?>
+-----
+<?php
+
+/** No namespace on purpose to simplify demo that case sensitive string should be marked as class-string */
+class ClassStringCaseSensitive
+{
+    /**
+     * @var class-string<\ClassStringCaseSensitive>
+     */
+    public $value;
+    public function set()
+    {
+        $this->value = 'ClassStringCaseSensitive';
+    }
+}
+
+?>