[ci-review] Rector Rectify

rectorphp · Oct 7, 2021 · 7d76851 · 7d76851
1 parent 89086c0
commit 7d76851
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php
@@ -149,7 +149,7 @@ private function matchClassMethodOnlyStmt(ClassMethod $classMethod): null | Stmt
             return null;
         }
 
-        if (count($classMethod->stmts) !== 1) {
+        if (count((array) $classMethod->stmts) !== 1) {
             return null;
         }
 

diff --git a/rules/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php b/rules/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php
@@ -14,7 +14,6 @@
 use PhpParser\Node\Stmt\Interface_;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\NodeFinder;
-use PHPStan\Analyser\MutatingScope;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ThisType;
@@ -37,7 +36,7 @@ final class FluentChainMethodCallNodeAnalyzer
      * Types that look like fluent interface, but actually create a new object.
      * Should be skipped, as they return different object. Not an fluent interface!
      *
-     * @var class-string<MutatingScope>[]
+     * @var string[]
      */
     private const KNOWN_FACTORY_FLUENT_TYPES = ['PHPStan\Analyser\MutatingScope'];
 

diff --git a/rules/Defluent/Rector/ClassMethod/NormalToFluentRector.php b/rules/Defluent/Rector/ClassMethod/NormalToFluentRector.php
@@ -78,7 +78,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $classMethodStatementCount = count($node->stmts);
+        $classMethodStatementCount = count((array) $node->stmts);
 
         // iterate from bottom to up, so we can merge
         for ($i = $classMethodStatementCount - 1; $i >= 0; --$i) {

diff --git a/rules/Defluent/Skipper/FluentMethodCallSkipper.php b/rules/Defluent/Skipper/FluentMethodCallSkipper.php
@@ -20,7 +20,7 @@ final class FluentMethodCallSkipper
      * Skip query and builder
      * @see https://ocramius.github.io/blog/fluent-interfaces-are-evil/ "When does a fluent interface make sense?
      *
-     * @var class-string[]
+     * @var string[]
      */
     private const ALLOWED_FLUENT_TYPES = [
         // symfony

diff --git a/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php b/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php
@@ -109,7 +109,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (count($node->stmts) === 1) {
+        if (count((array) $node->stmts) === 1) {
             /** @var Expression|Expr $stmt */
             $stmt = $node->stmts[0];
             if (! $stmt instanceof Expression) {