[DeadCode] Ensure $hasChanged not replaced on next iteration when it …

…assigned to true on RemoveUnusedPrivateMethodParameterRector (#5009)
rectorphp · Sep 12, 2023 · 7e2bc14 · 7e2bc14
1 parent 09baf7d
commit 7e2bc14
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php
@@ -220,7 +220,10 @@ private function clearPhpDocInfo(ClassMethod $classMethod, array $unusedParamete
                 continue;
             }
 
-            $hasChanged = $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $paramTagValueNode);
+            $hasTagRemoved = $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $paramTagValueNode);
+            if ($hasTagRemoved) {
+                $hasChanged = true;
+            }
         }
 
         if ($hasChanged) {