[Performance] Using findFirst() for cast to (bool) so no need search …

…all found nodes (#3642) * [Performance] Using findFirst() for cast to (bool) so no need search all found node * rollback negation * findFirst should be ok for negation, since it can return true on found
rectorphp · May 8, 2023 · 814aa5b · 814aa5b
1 parent 49e79bd
commit 814aa5b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rules/CodeQuality/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector.php b/rules/CodeQuality/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector.php
@@ -131,7 +131,7 @@ private function findPreviousAssignToArrayKeys(FuncCall $funcCall, Expr $expr):
             }
 
             if (! $node instanceof Assign) {
-                return ! (bool) $this->betterNodeFinder->find(
+                return ! (bool) $this->betterNodeFinder->findFirst(
                     $node,
                     fn (Node $subNode): bool => $this->nodeComparator->areNodesEqual($expr, $subNode)
                 );

diff --git a/src/NodeManipulator/ClassConstManipulator.php b/src/NodeManipulator/ClassConstManipulator.php
@@ -40,7 +40,7 @@ public function hasClassConstFetch(ClassConst $classConst, ClassReflection $clas
             }
 
             // has in class?
-            $isClassConstFetchFound = (bool) $this->betterNodeFinder->find($ancestorClass, function (Node $node) use (
+            $isClassConstFetchFound = (bool) $this->betterNodeFinder->findFirst($ancestorClass, function (Node $node) use (
                 $classConst,
                 $className
             ): bool {