Prevent unnecessary IO in ChangedFilesDetector (#3650)

* Prevent unnecessary IO in ChangedFilesDetector * Docs
rectorphp · Apr 22, 2023 · 81e7980 · 81e7980
1 parent d777f36
commit 81e7980
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/Caching/Detector/ChangedFilesDetector.php b/packages/Caching/Detector/ChangedFilesDetector.php
@@ -35,11 +35,16 @@ public function addFileWithDependencies(string $filePath, array $dependentFiles)
 
     public function hasFileChanged(string $filePath): bool
     {
-        $currentFileHash = $this->hashFile($filePath);
         $fileInfoCacheKey = $this->getFilePathCacheKey($filePath);
-
         $cachedValue = $this->cache->load($fileInfoCacheKey, CacheKey::FILE_HASH_KEY);
-        return $currentFileHash !== $cachedValue;
+
+        if ($cachedValue !== null) {
+            $currentFileHash = $this->hashFile($filePath);
+            return $currentFileHash !== $cachedValue;
+        }
+
+        // we don't have a value to compare against. Be defensive and assume its changed
+        return true;
     }
 
     public function invalidateFile(string $filePath): void