[Core][Symfony] Handle crash on get dynamic value ClassConstFetch by …

…method call on ChangeStringCollectionOptionToConstantRector (#2984)

* [Core][Symfony] Handle crash on get dynamic value ClassConstFetch by method call on ChangeStringCollectionOptionToConstantRector

* Fixed 🎉

* Fixed 🎉

* Fixed 🎉

src/PhpParser/Node/Value/ValueResolver.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\MagicConst\Dir;
 use PhpParser\Node\Scalar\MagicConst\File;
@@ -185,7 +186,7 @@ private function getConstExprEvaluator(): ConstExprEvaluator
             }
 
             // resolve "SomeClass::SOME_CONST"
-            if ($expr instanceof ClassConstFetch) {
+            if ($expr instanceof ClassConstFetch && $expr->class instanceof Name) {
                 return $this->resolveClassConstFetch($expr);
             }
 

tests/Issues/Issue7536/DynamicExprConstantTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\Issue7536;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+/**
+ * @see https://github.com/rectorphp/rector/issues/7536
+ */
+final class DynamicExprConstantTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    /**
+     * @return Iterator<array<string>>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/Issue7536/Fixture/skip_dynamic_class_const_fetch.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\Issue7536\Fixture;
+
+use Symfony\Component\Form\FormInterface;
+
+class SkipDynamicClassConstFetch
+{
+    private function pocMethod(FormInterface $childType, FormInterface $parentType)
+    {
+        $parentType->add(
+           $childType->methodA(),
+           $childType->methodB()::class
+        );
+    }
+}

tests/Issues/Issue7536/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Rector\MethodCall\ChangeStringCollectionOptionToConstantRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(ChangeStringCollectionOptionToConstantRector::class);
+};