[Php55] Check str_contains * before fnmatch() early on StringClassNam…

…eToClassConstantRector (#4990)
rectorphp · Sep 11, 2023 · 878f381 · 878f381
1 parent bfb7590
commit 878f381
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php b/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
@@ -176,11 +176,15 @@ private function shouldSkip(string $classLikeName): bool
         }
 
         foreach ($this->classesToSkip as $classToSkip) {
-            if ($this->nodeNameResolver->isStringName($classLikeName, $classToSkip)) {
-                return true;
+            if (str_contains($classToSkip, '*')) {
+                if (fnmatch($classToSkip, $classLikeName, FNM_NOESCAPE)) {
+                    return true;
+                }
+
+                continue;
             }
 
-            if (fnmatch($classToSkip, $classLikeName, FNM_NOESCAPE)) {
+            if ($this->nodeNameResolver->isStringName($classLikeName, $classToSkip)) {
                 return true;
             }
         }